Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/profile/solve editprofile bug #363

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Conversation

Harrish92
Copy link
Contributor

Solve editprofile bug

Description

This PR introduces a solution to the crash caused by the photo gallery in EditProfile . It closes issue #351 .

Changes

  • Verified that variables are not null.
  • Made sure that the code is safely encapsulated.

Files

Modified

  • app/src/main/java/com/android/periodpals/ui/components/ProfileComponents.kt
  • app/src/main/java/com/android/periodpals/ui/profile/EditProfile.kt
  • app/src/main/java/com/android/periodpals/ui/profile/ProfileScreen.kt

Testing

  • This PR does not include testing, since it refactors pre-written code.

@Harrish92 Harrish92 self-assigned this Dec 20, 2024
@Harrish92 Harrish92 linked an issue Dec 20, 2024 that may be closed by this pull request
5 tasks
Copy link
Contributor

@charliemangano charliemangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job introducing better practices in this code, it's always good to check null values and here it even fixes a bug!

@Harrish92 Harrish92 marked this pull request as ready for review December 20, 2024 05:35
@coaguila coaguila self-requested a review December 20, 2024 05:44
Copy link
Contributor

@coaguila coaguila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harrish92 Harrish92 merged commit f77cee6 into main Dec 20, 2024
3 checks passed
@Harrish92 Harrish92 deleted the fix/profile/solve-editprofile-bug branch December 20, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve EditProfile Bug
3 participants